Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopping cart bug fixes 1 #144

Closed
wants to merge 5 commits into from

Conversation

amenconi
Copy link
Contributor

In this PR I've added the following:

  • When cart checkout modal is closed and purchase transaction is successful then send notification that purchase transaction was successful, set step to CONFIRM and remove bought NFTs from cart.
  • General bug fixes with managing pending transaction state while cart checkout modal is closed.

Pushing this to also test on production environment due to not being able to replicate another reported bug by @emmap3-do :

Bloom deep link not present on bulk or single NFT checkout component.

Normally when the Bloom deep link isn't present it is due to requiring a valid network (where Firefly and TanglePay deep links don't require this). In debug, tested collection NFTs did show correct network and Bloom deep link was present. Will perform test for reported production collection to see if I replicate the issue.

@amenconi amenconi added the bug Something isn't working label Mar 19, 2024
@amenconi amenconi requested a review from adamunchained March 19, 2024 04:13
@amenconi amenconi self-assigned this Mar 19, 2024
@amenconi amenconi changed the base branch from master to develop March 19, 2024 04:13
Copy link

cloudflare-workers-and-pages bot commented Mar 19, 2024

Deploying prod-soonaverse-pr-previews with  Cloudflare Pages  Cloudflare Pages

Latest commit: f500d5b
Status: ✅  Deploy successful!
Preview URL: https://a2099a8e.app-cqo.pages.dev
Branch Preview URL: https://amenconi-shopping-cart-bug-f.app-cqo.pages.dev

View logs

@emmap3-do
Copy link
Contributor

@amenconi I tested and confirm the Bloom button is available and working on the cart checkout process.

Also, items are removed from cart once transaction succeeded (as expected) and last step shows the following:

image

But, the Bloom button is not available when I try to mint NFTs from the same SFT collection (no matter if qty = 1 or more) and I press the "Buy now" button, see:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants